Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify using fleet api has lots of drawbacks #4173

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

JakobLichterfeld
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld commented Aug 31, 2024

Thank you. Since you were the first to stumble, you won't be the last. So I am always open to improvements and I understand your point.
This was the point that stopped me from merging or implementing the Fleet API in the first place, as there are only drawbacks for 99.9% of users.
Using the fleet API is not recommended and has not been recommended in any issue or discussion.
The name official indicates something else, I got this point.

Originally posted by @JakobLichterfeld in #4081 (comment)

@JakobLichterfeld JakobLichterfeld added the kind:documentation Adds or improves documentation label Aug 31, 2024
@JakobLichterfeld JakobLichterfeld linked an issue Aug 31, 2024 that may be closed by this pull request
1 task
Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 4977fb9
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/66d30d5fd0a9f100081feb86
😎 Deploy Preview https://deploy-preview-4173--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld changed the title doc: fix markdownlint warnings in fleet api documentation doc: clarify using fleet api has lots of drawbacks Aug 31, 2024
@JakobLichterfeld
Copy link
Collaborator Author

@JakobLichterfeld JakobLichterfeld marked this pull request as ready for review August 31, 2024 12:34
@emilecantin
Copy link

@JakobLichterfeld Yeah, this is much clearer, thanks!

@JakobLichterfeld JakobLichterfeld merged commit fedb206 into master Aug 31, 2024
14 checks passed
@JakobLichterfeld JakobLichterfeld deleted the doc-fleet-api branch August 31, 2024 14:32
@jlestel
Copy link
Contributor

jlestel commented Sep 10, 2024

Great job 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unauthorized using Tesla Fleet API directly
3 participants